Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Livewire column doesn't have title() method #1994

Closed
wants to merge 2 commits into from
Closed

Livewire column doesn't have title() method #1994

wants to merge 2 commits into from

Conversation

ChrisThompsonTLDR
Copy link
Contributor

The Livewire column type doesn't have the HasTitleCallback trait, so you can't use ->title().

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

lrljoe and others added 2 commits October 1, 2024 00:20
@lrljoe @matzeschmitt @khwadj
v3.4.22 Master Release (#1972)
7d265a3 
* Add explanation of setRefreshMethod (#1857)

* Unlocking Entangled Items (#1859)

* Unlock properties locked in error

---------

Co-authored-by: lrljoe <[email protected]>

* Add dispatch on updated filter components (#1861)

* Add additional dispatch

* Add FilterApplied Event

* Add Filter Event Dispatch Tests

---------

Co-authored-by: lrljoe <[email protected]>

* v3.4.8

* Fix superfluous bulk actions tr < (#1868)

* Default useComputedProperties to False (#1869)

* Update ChangeLog

* Add Action Buttons (#1864)

* Make ActionButtons An Optional Feature in Beta


---------

Co-authored-by: lrljoe <[email protected]>

* FixDateRangeFilter (#1872)

* Adjust Methods - useComputedProperties (#1873)

* Adjust Methods - useComputedProperties

* Adjust ActionTest

* Update ChangeLog

* AllowDeleteDateRangeFilter (#1875)

* Fix ChangeLog

* Update Docs (#1876)

* Update ChangeLog - Add Docs Update

* Add setIconLeft/setIconRight (#1877)

* Add setIconLeft/setIconRight

* Fix styling

* Adjust Test

* Adjust ActionTest

---------

Co-authored-by: lrljoe <[email protected]>

* Adjust ChangeLog

* Adjust Action Button Icon Margin (#1880)

* Adjust Action Button Icon Margin

* Adjust ChangeLog

* Change Order of "Getting Started" section (#1883)

* Change Order of "Getting Started" section

* Change to "UsersTable"

* Add Button with No Icon (#1887)

* Add a "Recommended" approach (#1886)

* Add a "Recommended" approach

* Add blurb to Recommended

* v3.4.13

* Set actions position (#1889)

* Add displayActionsInToolbar and actionsPosition

* Add docs and tests for setActionsInToolbar

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Update ChangeLog

* Doc Type Fixes (#1891)

* Update NumberFilter and TypeHints

* Update DateFilter/DateTimeFilter and ConfigurableAreasHelpers for typehints and array key exists

* Add Float Test for NumberFilter

* Add ColorColumn View Test

* Adjust ColumnSelectConfigurationTest

---------

Co-authored-by: lrljoe <[email protected]>

* BooleanColumn - Toggleable Callback (#1892)

* Add Docs, Code for Toggleable Columns

* Add Confirmation Option

* Tweak Blade - Standardise

* Add Tests for Toggleable

---------

Co-authored-by: lrljoe <[email protected]>

* Update ChangeLog

* Enable/Disable Tools/Toolbar (#1896)

* Customised Toolbar Approach


---------

Co-authored-by: lrljoe <[email protected]>

* Use Computed Properties By Default (#1898)

* Fix has actions (#1901)

* Fix Action Repetitive Calling

* Fix validActionsCount

---------

Co-authored-by: lrljoe <[email protected]>

* Add icon column (#1902)

* Initial Commit - Awaiting Docs & Tests

* Tweak to IconColumn label behaviour

* Adding IconColumn documentation

* Add Additional Tests - Replace Test Database

* Add Visuals Test for IconColumn

* Add Icon Columns to Other Column Types

* Undo FrontendAssetsTest Changes

---------

Co-authored-by: lrljoe <[email protected]>

* Add Baseline - Convert phpstan.neon to tabs (#1903)

* Update ChangeLog

* Save filter selection to session (BETA) (#1910)

* Initial Commit

* Fix styling

* Initial Commit

* Fix styling

* Fix nullable return

* Add Initial Tests - Remove Non-Required Method

* Fix styling

* Swap methods

* Add default docs

* Remove errant note

* Adjust docs

* Adjust Docs for storeFiltersInSessionEnabled

---------

Co-authored-by: lrljoe <[email protected]>

* Add hide table option (#1914)

* Initial Commit

* Fix styling

* Further adjustments

* Fix styling

* Improve Tests - Extend PetsTable

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Add column select session methods (#1913)

* Initial Commit

* Fix styling

* Minor Tweaks

* Fix styling

* Fix Tests

* Add Tests for StoredColumnSelect

* Fix styling

* Add Missing Tests

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Use Core HasTheme Methods (#1915)

* Centralise Theme Methods

* Fix styling

* Fix for broken tests

* Fix styling

* Remove persisted computed properties

---------

Co-authored-by: lrljoe <[email protected]>

* Use Core Attribute Bag (#1916)

* Initial Commit

* Fix styling

* Add Missing Test

* Fix styling

* Adjustments

* Fix styling

* Adjust Test

* Fix styling

* Fix Sorting Visual Test

---------

Co-authored-by: lrljoe <[email protected]>

* Fix ChangeLog

* Add Polish translation by @meavric (#1925)

* Add Polish translation by @meavric

* Update ChangeLog to reflect translation

* Add Vertical Scrolling Example (#1926)

* Adjusting contributing

* Fix missing variable in workflow (#1933)

* Fix missing variable name

* Remove phpunit failOnWarning

* Tests

* PCOV Use Laravel 11

* Fixes for ButtonGroupColumn, ImageColumn, LinkColumn - to not default as label if has a "from" property. (#1932)

* Initial Commit - Allowing Labels with "From" to be included in queries

* Fix styling

* Fixes for ButtonGroupColumn, ImageColumn, LinkColumn - to not default as label if has a "from" property.

---------

Co-authored-by: lrljoe <[email protected]>

* Add button type to tailwind pagination blade template (#1928)

* v3.4.19 ChangeLog

* Revert tableName to be public (#1937)

* v3.4.20 ChangeLog

* Migration to Core attribute management (#1943)

* Migration to Core attribute management

* Fix styling

* Fix missing type hint, update tests

* Fix styling

* Remove defaults from being output

* Fix styling

* Adjust defaults

* Adjust behaviour for Bulk Actions TH

* Add "styling" to Columns docs

* Docs Adjust, add missing test

* Fix styling

* Adjust workflows - use L11 for PHPStan, use PHPUnit for L10

* Add missing test for thSortIconAttributes

* Fix styling

* Add CustomAttributesTest

* Fix styling

* Add missing tests - correct attribute to respect defaults

* Fix styling

* Remove defined processes in workflows

* Add test for setShouldBeHidden and setShouldBeDisplayed

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Update docs - add Action setLabelAttributes method (#1952)

* Reset Page on "Per Page" changing (#1953)

* Localisation - Avoid Conflicts With Other Packages (#1955)

* Merging Localisation Tweaks

* Fix styling

* Tweak localisations

* Fix styling

* Tweaks to sorting pill direction label

* Fix styling

* Fixes for Sorting Pill Labels

---------

Co-authored-by: lrljoe <[email protected]>

* Add filterComponents into queryString (#1957)

* Fix syntax for DateColumn outputFormat in docs (#1960)

* Fix Filter Pills Icon - Tailwind (#1961)

* Add original translation strings - for use in published views (#1959)

* Fix for Search Field Attribute Defaults (#1962)

* Fix for Search Field Attribute Defaults

* SearchFieldAttributes -> Defaults To False

* Change the type of LaravelLivewireTablesEvent::$user from Illuminate\Foundation\Auth\User to Illuminate\Contracts\Auth\Authenticatable (#1963)

* Remove persist from getFilterGenericData (#1966)

* Update ChangeLog

* Update Pint Workflow (#1967)

* Update Pint Workflow

* Update ChangeLog

* Test Styling Workflow

* Fix styling

* Test Workflow

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Update Discord Releases Workflow (#1968)

* Update ChangeLog

* Fix Loading Placeholder Bug - Breaking Table (#1969)

* FixLoadingPlaceholderBug

* Adjust tests for new Loading blade

* v3.4.22 ChangeLog

* Update ChangeLog

* Add comment on getTitle (#1976)

* Add before-wrapper and after-wrapper configurable areas (#1977)

* Add initial commit for setPaginationWrapperAttributes (#1978)

* Add initial commit for setPaginationWrapperAttributes

* Fix styling

* Update ChangeLog

* Adjust Tests & Methods

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Update ChangeLog

* Update ChangeLog

* Adjust ChangeLog Date

* Add ToolsAttributes and ToolbarAttributes (#1982)

* Initial Commit

* Fix styling

* Add getCustomAttributesBagFromArray

* Fix styling

* Reorder Array

* Reorder Initial Array - Add Additional Test

* Fix styling

* Add More Tests

---------

Co-authored-by: lrljoe <[email protected]>

* Add docs for the ColumnSelect lifecycle hooks (#1983)

* Add setToolsAttributes and setToolBarAttributes docs (#1984)

* Update ChangeLog

---------

Co-authored-by: lrljoe <[email protected]>
Co-authored-by: Matthias Schmitt <[email protected]>
Co-authored-by: Paoulo Riveros <[email protected]>
@ChrisThompsonTLDR
Livewire column doesn't have title() method
cd03aa3 
The Livewire column type doesn't have the `HasTitleCallback` trait, so you can't use `->title()`.
@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.19%. Comparing base (0c8ec45) to head (cd03aa3).
Report is 129 commits behind head on development.

Additional details and impacted files 
@@                Coverage Diff                @@
##             development    #1994      +/-   ##
=================================================
+ Coverage          87.30%   88.19%   +0.88%     
- Complexity          1672     1855     +183     
=================================================
  Files                150      174      +24     
  Lines               3891     4285     +394     
=================================================
+ Hits                3397     3779     +382     
- Misses               494      506      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe changed the base branch from master to development October 18, 2024 02:30
@lrljoe
Copy link
Collaborator

lrljoe commented Oct 18, 2024

Changing base to "development"

@lrljoe
Copy link
Collaborator

lrljoe commented Oct 20, 2024

@ChrisThompsonTLDR - looks like you created your patch off of the "master" branch, rather than "development". So there's some oddities in the PR that makes it look like you've changed a lot more than you actually have.

Could you please either rebase your branch on "development", or create a new PR based on "development"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisThompsonTLDR @lrljoe